Skip to content

tools: enable linter in test/fixtures/source-map/output #57700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 1, 2025

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (caf478b) to head (5944bf6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57700      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.01%     
==========================================
  Files         630      630              
  Lines      184990   184990              
  Branches    36216    36213       -3     
==========================================
- Hits       166954   166950       -4     
+ Misses      11003    10993      -10     
- Partials     7033     7047      +14     

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 87f8d3c into nodejs:main Apr 4, 2025
19 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 4, 2025

Landed in 87f8d3c

@aduh95 aduh95 deleted the lint-source-map-output branch April 4, 2025 13:56
@@ -62,6 +62,14 @@ export default [
'!test/fixtures/console',
'!test/fixtures/errors',
'!test/fixtures/eval',
'!test/fixtures/source-map',

This comment was marked as off-topic.

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request May 19, 2025
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants