Skip to content

doc: list DOMException as a potential error raised by Node.js #57783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

doc: list DOMException as a potential error raised by Node.js #57783

merged 1 commit into from
Apr 9, 2025

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Apr 7, 2025 •
edited
Loading

List DOMException as a potential error type raised by Node.js in errors.md, along with
standard JS error types.

This should also clarify that a change to DOMException message does not need semver-major.

Refs: #57735

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Apr 7, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit d6b062c into nodejs:main Apr 9, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d6b062c

@legendecas legendecas deleted the doc/errors branch April 9, 2025 12:16
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@legendecas @JonasBa
doc: list DOMException as a potential error raised by Node.js
0270f19 
PR-URL: nodejs#57783
Refs: nodejs#57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas @RafaelGSS
doc: list DOMException as a potential error raised by Node.js
a4e305a 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas @RafaelGSS
doc: list DOMException as a potential error raised by Node.js
a5ef2e8 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
31d167e 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@legendecas @RafaelGSS
doc: list DOMException as a potential error raised by Node.js
602bf9f 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
0877fb2 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
972d3ba 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
c6e5a43 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
81720df 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
01cad99 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@jazelly jazelly jazelly approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@legendecas @nodejs-github-bot @ljharb @jasnell @anonrig @aduh95 @jazelly