Skip to content

Revert "test: add tests for REPL custom evals" #57793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Revert "test: add tests for REPL custom evals" #57793

merged 1 commit into from
Apr 8, 2025

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 8, 2025

This reverts commit 1f7cfb7, which, as far as I can tell, was merged into the main branch despite relevant test failures.

The new test also started showing up in reliability reports immediately, see nodejs/reliability#1167.

Refs: #57691 (comment)

@tniessen
Revert "test: add tests for REPL custom evals"
10a3e43 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 8, 2025
@tniessen tniessen requested a review from aduh95 April 8, 2025 14:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Apr 8, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14335840440

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (1540fc6) to head (10a3e43).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57793      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.02%     
==========================================
  Files         630      630              
  Lines      185288   185289       +1     
  Branches    36344    36342       -2     
==========================================
- Hits       167203   167178      -25     
- Misses      11006    11009       +3     
- Partials     7079     7102      +23
Files with missing lines Coverage Δ
lib/repl.js 94.91% <100.00%> (+<0.01%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Apr 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66135/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2025
BridgeAR
BridgeAR approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66142/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2025
@nodejs-github-bot nodejs-github-bot merged commit a6cc240 into nodejs:main Apr 8, 2025
80 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a6cc240

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@tniessen @JonasBa
Revert "test: add tests for REPL custom evals"
274e418 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: nodejs#57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
5699d5c 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
8c394e5 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
@dario-piotrowicz dario-piotrowicz mentioned this pull request Apr 12, 2025
Draft
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
9413135 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 12, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
1e33c67 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request Apr 18, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
584b6d9 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output, wasn't taking into
account that input processing and output emitting are asynchronous
operation can resolve with a small delay
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@tniessen @RafaelGSS
Revert "test: add tests for REPL custom evals"
ea5e60d 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@tniessen @RafaelGSS
Revert "test: add tests for REPL custom evals"
12f4124 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@tniessen @aduh95
Revert "test: add tests for REPL custom evals"
03a949c 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 11, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
8196294 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 11, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
c93bded 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@tniessen @RafaelGSS
Revert "test: add tests for REPL custom evals"
be0d9f0 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@tniessen @aduh95
Revert "test: add tests for REPL custom evals"
5a2d45e 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@tniessen @aduh95
Revert "test: add tests for REPL custom evals"
ce84d67 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@tniessen @aduh95
Revert "test: add tests for REPL custom evals"
92c2321 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@tniessen @aduh95
Revert "test: add tests for REPL custom evals"
1749cf6 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 18, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
a98d47f 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@tniessen @aduh95
Revert "test: add tests for REPL custom evals"
c6a45a9 
This reverts commit 1f7cfb7, which was
merged into the main branch despite relevant test failures.

PR-URL: #57793
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
dario-piotrowicz added a commit to dario-piotrowicz/node that referenced this pull request May 23, 2025
@dario-piotrowicz
test: add tests for REPL custom evals
009ae33 
this commit reintroduces the REPL custom eval tests that have
been introduced in nodejs#57691
but reverted in nodejs#57793

the tests turned out problematic before because `getReplOutput`,
the function used to return the repl output wasn't taking into
account that input processing and output emitting are asynchronous
operation can can resolve with a small delay
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @lpinca @cjihrig @richardlau @BridgeAR @aduh95