doc: correct deprecation type of assert.CallTracker
#57997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-ippolito
approved these changes
Apr 24, 2025
jasnell
approved these changes
Apr 24, 2025
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
|
Really no reason for this one to wait the 48 hours. |
Commit Queue failed- Loading data for nodejs/node/pull/57997 ✔ Done loading data for nodejs/node/pull/57997 ----------------------------------- PR info ------------------------------------ Title doc: correct deprecation type of `assert.CallTracker` (#57997) Author René <[email protected]> (@Renegade334) Branch Renegade334:doc-calltracker-deprecation -> nodejs:main Labels doc, fast-track, author ready, deprecations, dont-land-on-v18.x Commits 1 - doc: correct deprecation type of `assert.CallTracker` Committers 1 - Renegade334 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57997 Refs: https://github.com/nodejs/node/pull/47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57997 Refs: https://github.com/nodejs/node/pull/47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 24 Apr 2025 07:01:00 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57997#pullrequestreview-2791347686 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57997#pullrequestreview-2791348226 ℹ This PR is being fast-tracked ✘ This PR needs to wait 38 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14647104058 |
lpinca
approved these changes
Apr 24, 2025
|
Landed in 6db150d |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
PR-URL: #57997 Refs: #47740 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert.CallTrackerwas runtime-deprecated at the outset.ref: #47740