BUG: Fix indexing on DatetimeBlock #27110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jun 28, 2019
pandas/core/internals/blocks.py
Outdated
| col, loc = col | ||
| if not com.is_null_slice(col) and col != 0: | ||
| raise IndexError("{0} only contains one item".format(self)) | ||
| if isinstance(col, slice): |
| assert ts == grouped.head(1)['B'].iloc[0] | ||
| assert ts == grouped.first()['B'].iloc[0] | ||
| assert ts == grouped.apply(lambda x: x.iloc[0])[0] | ||
| assert ts == grouped.apply(lambda x: x.iloc[0]).iloc[0, 0] |
Contributor
There was a problem hiding this comment.
can you reference this issue and maybe put a comment here on whey this is like this
Contributor
There was a problem hiding this comment.
or this is actually returning a single column DataFrame right? can you assert that
| ts = df['B'].iloc[2] | ||
| assert ts == grouped.last()['B'].iloc[0] | ||
| assert ts == grouped.apply(lambda x: x.iloc[-1])[0] | ||
| # FIXME: the next assertion is wrong; GH#26864 |
Contributor
There was a problem hiding this comment.
also ok with moving these to a new test if easier
Member
Author
|
I'm pretty sure this problem also affects other EA blocks, will check and add tests if so |
Member
Author
|
@jreback any idea what’s up with the CI? |
Contributor
|
Contributor
|
method -> meth in the whatnew |
jreback
approved these changes
Jul 1, 2019
Contributor
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffAddresses one of the problems behind #26864, but probably doesn't address the statefullness problem there.