BUG: Fix ndarray + DataFrame ops #23114
Conversation
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
pandas/core/generic.py
Outdated
| len(context[1]) == 2 and context[1][1] is self and | ||
| isinstance(context[1][0], np.ndarray)): | ||
| # TODO: Can we return NotImplemented earlier? By the time we | ||
| # get here we've calculated `result`, which may not be cheap |
There was a problem hiding this comment.
@shoyer any idea if there is a more elegant way to do this?
There was a problem hiding this comment.
What are you trying to fix here? Generally I recommend avoiding __array_wrap__ if possible... __array_ufunc__ is a much more complete interface. To be honest, I'm not even sure if returning NotImplemented from __array_wrap__ has well-defined behavior.
There was a problem hiding this comment.
What are you trying to fix here?
#22537. In master ndarray[int] + DataFrame[timedelta64[ns]] treats the ndarray as timedelta64 instead of raising TypeError.
There was a problem hiding this comment.
I'm not familiar with exactly how pandas implements binary ops, but this doesn't look like the right place to fix this.
The problem is likely in the DataFrame.__radd__ or DataFrame.__array_ufunc__ method (which NumPy calls instead of __radd__ if defined, see here for details and recommendations)
There was a problem hiding this comment.
Thanks. Looks like its extra-simple: Series and Index both define __array_priority__ but DataFrame does not.
There was a problem hiding this comment.
Wow, I'm kind of surprised we never defined DataFrame.__array_priority__ :)
Codecov Report
@@ Coverage Diff @@
## master #23114 +/- ##
==========================================
+ Coverage 92.13% 92.13% +<.01%
==========================================
Files 170 170
Lines 51073 51074 +1
==========================================
+ Hits 47056 47057 +1
Misses 4017 4017
Continue to review full report at Codecov.
|
jreback
left a comment
There was a problem hiding this comment.
can you add a whatsnew note. prob need a small example for this.
|
lgtm |
|
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff