Update description of Index._values/values/ndarray_values #23507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jorisvandenbossche! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23507 +/- ##
=========================================
Coverage ? 92.23%
=========================================
Files ? 161
Lines ? 51197
Branches ? 0
=========================================
Hits ? 47220
Misses ? 3977
Partials ? 0
Continue to review full report at Codecov.
|
TomAugspurger
approved these changes
Nov 5, 2018
gfyoung
approved these changes
Nov 5, 2018
Member
gfyoung
left a comment
There was a problem hiding this comment.
@jbrockmendel : If this looks good to you, go and merge!
jreback
reviewed
Nov 5, 2018
pandas/core/indexes/base.py
Outdated
| index | values | _values | _ndarray_values | | ||
| ----------------- | --------------- | ------------- | --------------- | | ||
| Index | ndarray | ndarray | ndarray | | ||
| CategoricalIndex | Categorical | Categorical | codes | |
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23504
@jbrockmendel @TomAugspurger