Skip to content

Fix build with mtl-2.3 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

9999years
Copy link
Contributor

mtl-2.3 no longer reexports Control.Monad

mtl-2.3 no longer reexports `Control.Monad`
@mjrussell
Copy link
Collaborator

Thanks for the PR! Because this project uses a stack.yaml and the LTS is set to 20.17, the MTL package version is already pinned to 2.2.2 (at least if you are building with stack, there's no cabal version bounds). If we want to release a new version for support in a later LTS, we should bump the stack snapshot first and fix any errors that appear through that.

It looks like there isn't any active snapshot that I see with MTL 2.3...we might need to wait for that.

Alternatively we could use CPP here to deal with the breaking changes

@mjrussell
Copy link
Collaborator

Oh, just realized since these are re-export of same function it should be ok. Let me just run this through CI and might be able to merge it

@mjrussell
Copy link
Collaborator

All good, thanks again!

@mjrussell mjrussell merged commit 6d6e15c into parsonsmatt:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants