Implemented PDO Driver specific SQL parsers #14035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00ef951 to
156d484
Compare
mvorisek
reviewed
Apr 23, 2024
mvorisek
reviewed
Apr 23, 2024
0c123a2 to
372740e
Compare
derickr
reviewed
May 9, 2024
372740e to
bf3aa65
Compare
|
pdo/pgsql part looks ok to me. |
|
odbc looks OK for me for obvious reasons :) |
ghostwriter
reviewed
May 15, 2024
There was a problem hiding this comment.
Great job on implementing the PDO Driver specific SQL parsers, @mbeccati!
I've reviewed and tested the pull request, and everything looks good to me.
Thanks for your contribution!
outtersg
reviewed
May 20, 2024
|
I haven't looked at everything yet, but dblib and firebird look good. |
16a26d4 to
74088a3
Compare
a9a4ecb to
209a1ab
Compare
209a1ab to
5f415fb
Compare
5f415fb to
6155d97
Compare
This required changing how YYFILL works, with no apparent regressions
Allow "??" in dollar quoted strings for backwards compatibility, as it was a viable workaround to insert question marks without them being parsed as placeholders. Add a deprecation notice to tell that the escape is no longer necessary within dollar quotes and that its usage is deprecated. Ref bug php#14244
6155d97 to
53d7c17
Compare
9da0d4b to
329dfa7
Compare
|
@mbeccati This PR broke the nightly build, can you please have a look? |
|
@iluuu1994 Thanks for the heads up. I'll look into it - I haven't been building PHP without mysqlnd since a long time, but this is totally unexpected. |
|
@iluuu1994 Fixed in 5a3c4a2 - Thanks again! |
|
Great, thanks for the quick resolution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: http://wiki.php.net/rfc/pdo_driver_specific_parsers