New 'cache_key' streams operation #1711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flaupretre any news on this? would love to get opcache in stream wrapped sources.. |
|
Yes, RFC will be written and discussed soon (as soon as I have enough time to write it :) |
|
@flaupretre fix conflicts please :) Please push forward with this RFC (if still applicable), alternatively, if you consider this work abandoned, please close this PR. |
|
RFC is under discussion: https://wiki.php.net/rfc/url-opcode-cache |
C API: php_stream_cache_key() PHP API: file_cache_key() Bump PHP_API_VERSION and enclose 'cache_key' definitions in conditional blocks Check key prefix (debug mode only) Implement new 'cache_key' streams operation C API: php_stream_cache_key() PHP API: file_cache_key() Bump PHP_API_VERSION and enclose 'cache_key' definitions in conditional blocks Check key prefix (debug mode only) Minor fixes (PHP_API_VERSION checks) Add key prefix check for userspace wrappers
|
Comment on behalf of kalle at php.net: Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for merge yet. Vote for the corresponding RFC is open.
This is a follow-up to #976.
The 'cache_key' operation allows opcode caches to ask stream wrappers whether a given URL should be cached, and the key to use. This will allow stream-wrapped URLs to be opcode-cached, which is impossible today, except for 'phar' and 'file" wrappers (hardcoded).