Normalize increment and decrement operator behaviour #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add notice when string increment is being used.
4ee2360 to
9a57cbc
Compare
|
Can one of the admins verify this patch? |
|
Comment on behalf of krakjoe at php.net: Since this has an RFC under discussion, I will not close this bug. It does have many many merge conflicts and is not in good shape. If you do not intend to move forward with this RFC, please close this PR and update the wiki. If you do intend to move forward with this RFC, please fix the merge conflicts. |
|
Having waited a month for feedback, and for merge conflicts to be solved - which is necessary for anyone who wants to test the patch, I'm going to have to close this PR, and will update the RFC accordingly. Please take this action as encouragement to open a clean PR against an appropriate target, and move forward with the prepared RFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/normalize_inc_dec
Status: In Draft