-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Attribute Amendments #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute Amendments #5751
Conversation
To avoid unnecessary back and forth in the AST representation, let's drop the grouped attribute syntax, which will dropped anyway once https://wiki.php.net/rfc/shorter_attribute_syntax finishes voting. |
Attribute grouping has been removed from the PR. |
@nikic All review comments have been addressed. I rebased the PR on latest master and squashed all commits into a single one. |
Implements all changes that have been proposed by @beberlei and myself in RFC: Attribute Amendments. Support for attribute grouping is left out because Shorter Attribute Syntax will likely make it obsolete. All new features are demonstrated in this little example:
These are the extensions to existing APIs: