Make instanceof useful for more things #6694
Closed
+99
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the RFC being drafted at https://wiki.php.net/rfc/instanceof_improvements
nikic
reviewed
Feb 15, 2021
| zend_uchar t = zend_lookup_builtin_type_by_name(Z_STR(class_node.u.constant)); | ||
|
|
||
| if (t == IS_NULL || t == _IS_BOOL || t == IS_LONG || t == IS_STRING || t == IS_DOUBLE || t == IS_OBJECT) { | ||
| zend_compile_func_typecheck_impl(result, obj_ast, t); |
There was a problem hiding this comment.
Needs a zval_ptr_dtor_nogc(&class_node.u.constant) to avoid leaking.
nikic
reviewed
Feb 15, 2021
| return; | ||
| } | ||
| } | ||
|
|
||
| opline = zend_emit_op_tmp(result, ZEND_INSTANCEOF, &obj_node, NULL); |
There was a problem hiding this comment.
ZEND_INSTANCEOF would have to be adjusted to make sure that you get the same behavior with a dynamic type name.
|
See also https://wiki.php.net/rfc/variable_syntax_tweaks#arbitrary_expression_support_for_new_and_instanceof for currently allowed syntax and the note in "Future Scope" on potential complications with omitted parentheses. |
|
@MaxSem Are you planning on pursuing an RFC for this? |
|
No, since then I noticed an RFC for |
|
Thanks, I closed the corresponding RFC as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the RFC being drafted at https://wiki.php.net/rfc/instanceof_improvements