WIP: driver specific PDO SQL parsers #6852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Apr 12, 2021
| @@ -308,6 +312,7 @@ struct pdo_dbh_methods { | |||
| /* if defined to NULL, PDO will use its internal transaction tracking state */ | |||
| pdo_dbh_txn_func in_transaction; | |||
| pdo_dbh_get_gc_func get_gc; | |||
| pdo_dbh_sql_parser parser; | |||
There was a problem hiding this comment.
parser -> scanner, here and elsewhere?
There was a problem hiding this comment.
I had a couple of branches, not 100% sure I pushed the very latest one.
I was a bit undecided between scanner and parser and went back and forth a number of times, but it sounds like scanner is the winner ;-)
|
I like this approach. |
|
Superseded by #14035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC of a pgsql specific parser, not fumbling on backslash characters, e.g. https://bugs.php.net/78534