Skip to content

Scalar Type Hints #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

Scalar Type Hints #998

wants to merge 27 commits into from

Conversation

hikari-no-yume
Copy link
Contributor

For version 0.2 of the RFC.

v0.1's pull request was here: #972

@hikari-no-yume hikari-no-yume force-pushed the scalar_type_hints_2_strict_mode branch 2 times, most recently from 403c887 to 9ec1340 Compare January 25, 2015 03:11
@hikari-no-yume
Copy link
Contributor Author

Hooray, it's green on travis! The only failures are tests that also fail in master.

@hikari-no-yume hikari-no-yume force-pushed the scalar_type_hints_2_strict_mode branch 2 times, most recently from 71e7fa5 to dc1cce4 Compare January 29, 2015 18:02
@mickaelandrieu
Copy link

👍 , one of the most missing feature in PHP.

Great proposal and work !

@hikari-no-yume
Copy link
Contributor Author

@mickaelandrieu Thanks! ^^

@hikari-no-yume
Copy link
Contributor Author

It's broken on Travis, it won't build and I really don't understand why :(

@hikari-no-yume hikari-no-yume force-pushed the scalar_type_hints_2_strict_mode branch from 121df65 to f4e1cca Compare February 5, 2015 19:25
@thekid thekid mentioned this pull request Feb 7, 2015
Closed
@hikari-no-yume hikari-no-yume force-pushed the scalar_type_hints_2_strict_mode branch from eee750f to f1647c5 Compare February 8, 2015 21:25
@hikari-no-yume
Scalar type hints with ZPP casting rules
c3c0f53
@hikari-no-yume
Do not make scalar type hints reserved words, merely reserve class name
75a225d
@hikari-no-yume
Use new names of arg parsing functions
d4dd2a9
@hikari-no-yume
Refactor scalar type hints implementation per Dmitry's patch
a13d134
@hikari-no-yume
Fix class name prohibition to work for namespaced classes, too
a03af7f
@hikari-no-yume
Forbid scalar type hint names for use, class_alias
1a28ad0
@hikari-no-yume
Inline
5544e37
@hikari-no-yume
It Begins
cc01e37
@hikari-no-yume
Per-file
02ec357
@hikari-no-yume
Partial ZPP strictness implementation
fe663cc
@hikari-no-yume
Add strict scalar types test
ca49012
@hikari-no-yume
Shorten syntax to strict_types=1
e1a2386
@hikari-no-yume
Test strict code calling weak code and vice-versa
b112c13
@hikari-no-yume
Fix usage of zend_wrong_param_count in ext/mysqli
2985944
@hikari-no-yume
Prefix zend_wrong_param_count with _ to discourage use
86b0685
@hikari-no-yume
Test strict code including weak code and vice-versa
17b3707
@hikari-no-yume
Fix fix
c6e8048
@hikari-no-yume hikari-no-yume force-pushed the scalar_type_hints_2_strict_mode branch from f1647c5 to d6bea5b Compare February 10, 2015 15:52
@hikari-no-yume
Copy link
Contributor Author

function foo(bool $foo = true) {} is broken, presumably because _IS_BOOL != IS_TRUE but I haven't checked

@allan-simon
Copy link

Hello, the RFC is now put as "withdrawn" on php.net, and I was not able to find a reason why, can you give a brief explanation, as that was a very promising feature.

@staabm
Copy link
Contributor

staabm commented Feb 28, 2015

@allan-simon their are 2 alternernative PR which implement typehints in a similar fashion

@allan-simon
Copy link

@staabm , is there a separate RFC associated to them or it's still the same RFC but just different implementation ?

@staabm
Copy link
Contributor

staabm commented Feb 28, 2015

See
https://wiki.php.net/rfc/scalar_type_hints_v5
https://wiki.php.net/rfc/coercive_sth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hikari-no-yume @mickaelandrieu @allan-simon @staabm @jpauli @dstogov