Skip to content

Fix tzlocal issue #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2022
Merged

Fix tzlocal issue #1126

merged 1 commit into from
May 7, 2022

Conversation

geier
Copy link
Member

@geier geier commented May 4, 2022

Newer versions of tzlocal return tzinfo timezones, not pytz ones. Khal
can't deal with tzinfo timezones for the moment, so we force pytz
timezones when we use tzlocal.

This should be removed when we completely migrate to tzinfo.

Fix #1092 #1087

@geier geier requested review from WhyNotHugo and ephase May 4, 2022 20:20
@geier geier force-pushed the fix/1092 branch 2 times, most recently from f6c2464 to 6b0a949 Compare May 4, 2022 21:04
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very smart approach. LGTM.

@geier geier force-pushed the fix/1092 branch 2 times, most recently from 23d70f5 to 415ee2f Compare May 5, 2022 17:10
Newer versions of tzlocal return tzinfo timezones, not pytz ones. Khal
can't deal with tzinfo timezones for the moment, so we force pytz
timezones when we use tzlocal.

This should be removed when we completely migrate to tzinfo.

Fix #1092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytz warnings when using khal
3 participants