Ruby | Add support for a protobuf debug build #21060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Menard <[email protected]> Co-authored-by: Randy Stauner <[email protected]>
|
Thanks for the contribution, @davebenvenuti While we wait for the test results from CI, could you update the docs in |
JasonLunn
approved these changes
Apr 4, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
This PR makes a small change to `extconf.rb` so we can easily build the `protobuf_c` Ruby bindings with all debug symbols included. We used [grpc](https://github.com/grpc/grpc/blob/master/src/ruby/ext/grpc/extconf.rb) as a guide, which will produce a debug build if `rake` is run with `GRPC_CONFIG=dbg`. Unlike `grpc`, the `protobuf_c` build doesn't explicitly strip symbols from the resulting library, but values will be optimized out when stepping through with `gdb`. Closes #21060 COPYBARA_INTEGRATE_REVIEW=#21060 from Shopify:ruby-debug-build 353b272 FUTURE_COPYBARA_INTEGRATE_REVIEW=#21060 from Shopify:ruby-debug-build 353b272 PiperOrigin-RevId: 744040924
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
This PR makes a small change to `extconf.rb` so we can easily build the `protobuf_c` Ruby bindings with all debug symbols included. We used [grpc](https://github.com/grpc/grpc/blob/master/src/ruby/ext/grpc/extconf.rb) as a guide, which will produce a debug build if `rake` is run with `GRPC_CONFIG=dbg`. Unlike `grpc`, the `protobuf_c` build doesn't explicitly strip symbols from the resulting library, but values will be optimized out when stepping through with `gdb`. Closes #21060 COPYBARA_INTEGRATE_REVIEW=#21060 from Shopify:ruby-debug-build 353b272 FUTURE_COPYBARA_INTEGRATE_REVIEW=#21060 from Shopify:ruby-debug-build 353b272 PiperOrigin-RevId: 744040924
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
This PR makes a small change to `extconf.rb` so we can easily build the `protobuf_c` Ruby bindings with all debug symbols included. We used [grpc](https://github.com/grpc/grpc/blob/master/src/ruby/ext/grpc/extconf.rb) as a guide, which will produce a debug build if `rake` is run with `GRPC_CONFIG=dbg`. Unlike `grpc`, the `protobuf_c` build doesn't explicitly strip symbols from the resulting library, but values will be optimized out when stepping through with `gdb`. This change also reconciles an oversight that `-fvisibility=hidden` was not set when building on non-Darwin/Linux/Freebsd platforms. Closes #21060 COPYBARA_INTEGRATE_REVIEW=#21060 from Shopify:ruby-debug-build 353b272 FUTURE_COPYBARA_INTEGRATE_REVIEW=#21060 from Shopify:ruby-debug-build 353b272 PiperOrigin-RevId: 744040924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to
extconf.rbso we can easily build theprotobuf_cRuby bindings with all debug symbols included. We used grpc as a guide, which will produce a debug build ifrakeis run withGRPC_CONFIG=dbg. Unlikegrpc, theprotobuf_cbuild doesn't explicitly strip symbols from the resulting library, but values will be optimized out when stepping through withgdb.