Skip to content

Add a test for #5758 part two #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gvanrossum opened this issue Oct 10, 2018 · 3 comments
Closed

Add a test for #5758 part two #5767

gvanrossum opened this issue Oct 10, 2018 · 3 comments

Comments

@gvanrossum
Copy link
Member

See #5762 (comment)
@gvanrossum gvanrossum self-assigned this Oct 10, 2018
@gvanrossum gvanrossum changed the title Add a test for #5758 Add a test for #5758 part two Oct 10, 2018
@chrisphilip322
Copy link
Contributor

I can work on this over the next week unless you were already on planning working on it.

gvanrossum added a commit that referenced this issue Oct 11, 2018
@gvanrossum
Fix some edge cases of namespace package imports (#5762)
725247b 
Fixes #5758. (Sadly there's no test for the second half of that issue; I've opened #5767 to track adding one.)
gvanrossum added a commit that referenced this issue Oct 11, 2018
@gvanrossum
Fix some edge cases of namespace package imports (#5762)
9d62ac8 
Fixes #5758. (Sadly there's no test for the second half of that issue; I've opened #5767 to track adding one.)
@gvanrossum
Copy link
Member Author

I can work on this over the next week

Please do!

@gvanrossum gvanrossum removed their assignment Oct 12, 2018
@chrisphilip322 chrisphilip322 mentioned this issue Oct 12, 2018
Merged
chrisphilip322 added a commit to chrisphilip322/mypy that referenced this issue Oct 12, 2018
@chrisphilip322
add testcase which closes python#5767
2b69726
@gvanrossum
Copy link
Member Author

Had we had this test, then this bug would (hopefully) have been found before releasing 0.640: #5784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvanrossum @chrisphilip322