-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Sync pythoncapi_compat #12188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync pythoncapi_compat #12188
Conversation
cc @vstinner @JelleZijlstra Am I doing the right way to update the LICENSE? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you just copied the file over? This makes sense to me but I don't know much about the C API, so let's also give Victor some time to confirm.
I changed pythoncapi_compat license so you don't have to mention pythoncapi_compat license to use it. Previously, the MIT license required you to mention it. I made a mistake when I copied pythoncapi_compat in mypy, I wasn't aware of the "advertizing" part of the MIT license. I suggest to leave the LICENSE file unchanged: don't mention pythoncapi_compat license. But you can mention the license if you want :-) |
What is the purpose of this change? To use the 0BSD license instead of the MIT license? If yes, it's a good thing :-) The MIT license must be mentioned in the projects using the old version of pythoncapi_compat (the old version using the MIT license). |
This issue was just closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Related mypyc/mypyc#889