Skip to content

Sync pythoncapi_compat #12188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Conversation

97littleleaf11
Copy link
Collaborator

@97littleleaf11 97littleleaf11 commented Feb 16, 2022

Related mypyc/mypyc#889

@97littleleaf11
Copy link
Collaborator Author

cc @vstinner @JelleZijlstra Am I doing the right way to update the LICENSE?

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you just copied the file over? This makes sense to me but I don't know much about the C API, so let's also give Victor some time to confirm.

@vstinner
Copy link
Member

cc @vstinner @JelleZijlstra Am I doing the right way to update the LICENSE?

I changed pythoncapi_compat license so you don't have to mention pythoncapi_compat license to use it.

Previously, the MIT license required you to mention it. I made a mistake when I copied pythoncapi_compat in mypy, I wasn't aware of the "advertizing" part of the MIT license.

I suggest to leave the LICENSE file unchanged: don't mention pythoncapi_compat license. But you can mention the license if you want :-)

@vstinner
Copy link
Member

What is the purpose of this change? To use the 0BSD license instead of the MIT license? If yes, it's a good thing :-) The MIT license must be mentioned in the projects using the old version of pythoncapi_compat (the old version using the MIT license).

@vstinner
Copy link
Member

Related mypyc/mypyc#889

This issue was just closed.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@97littleleaf11 97littleleaf11 merged commit 2c9a8e7 into python:master Feb 22, 2022
@97littleleaf11 97littleleaf11 deleted the sync-pythoncapi branch February 22, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants