Skip to content

[mypyc] Implement additional ircheck checks #12191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Conversation

jhance
Copy link
Collaborator

@jhance jhance commented Feb 16, 2022

This includes checks for:

  • duplicate op (caused obscure bug in developing another PR that was hard to debug)
  • Call operations
  • Control ops
  • Literal loads
  • Assignments and Return (basic type coercion checking)

Check op/register validity and check type coercions for return
and assign.
In particular, this will catch the case where builder.add() is
called twice, which causes very weird bogus IR.
@97littleleaf11
Copy link
Collaborator

Basically lgtm. But it's my first time to look into analysis/ircheck.py so I'd like to wait for someone else to double check and merge it!

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JukkaL JukkaL merged commit c7365ef into python:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants