Skip to content

Remove orjson stubs from default list #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

hauntsaninja
Copy link
Collaborator

@srittau
Copy link
Contributor

srittau commented Mar 1, 2022

Would it make sense to remove all packages (except cryptography) that already have a scheduled release date? Upstream packages already have types, agree all.

@hauntsaninja
Copy link
Collaborator Author

I think it makes sense to remove all packages that have a py.typed release — but I took a gander and I think you've already removed all of them :-)

@srittau
Copy link
Contributor

srittau commented Mar 1, 2022

Upstream packages already have types, agree all.

This happens when you type on your phone. And I don't remember what I wanted to say instead of "agree all".

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 187f394 into python:master Mar 1, 2022
@hauntsaninja hauntsaninja deleted the orj branch March 1, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants