stubtest: Private parameters can be omitted

[srittau]

Fixes #16443

[srittau]

As opposed to what I suggested in the issue, I implemented it so the parameter name can start with at least one underscore. It doesn't require exactly one. I wouldn't be surprised if some people start their private parameter names with a double underscore.

[AlexWaygood]

As opposed to what I suggested in the issue, I implemented it so the parameter name can start with at least one underscore. It doesn't require exactly one. I wouldn't be surprised if some people start their private parameter names with a double underscore.

Hmm, until we dropped support for Python 3.7, typing_extensions had a lot of parameters that started with __ (to signify as best we could that they were meant to be positional-only). I don't think we necessarily considered them to be private parameters:

• https://github.com/python/typing_extensions/blob/b518f6a64400fd5a25e5b72668370b9792ef9ae6/src/typing_extensions.py#L1080
• https://github.com/python/typing_extensions/blob/b518f6a64400fd5a25e5b72668370b9792ef9ae6/src/typing_extensions.py#L1189
• https://github.com/python/typing_extensions/blob/b518f6a64400fd5a25e5b72668370b9792ef9ae6/src/typing_extensions.py#L2310
• https://github.com/python/typing_extensions/blob/b518f6a64400fd5a25e5b72668370b9792ef9ae6/src/typing_extensions.py#L2333
• https://github.com/python/typing_extensions/blob/b518f6a64400fd5a25e5b72668370b9792ef9ae6/src/typing_extensions.py#L2451

I think I preferred what was suggested in the issue: other packages might do similarly, and might not have updated their parameter names even if they've since dropped support for Python 3.7.

[srittau]

That's a good point. I'll update the PR.

[AlexWaygood]

LGTM

[srittau]

Can I bump this PR? It seems there are no further objections.