Skip to content

Add is_lvalue attribute to AttributeContext #17881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2024
Merged

Add is_lvalue attribute to AttributeContext #17881

merged 5 commits into from
Oct 6, 2024

Conversation

brianschubert
Copy link
Collaborator

Refs #17878

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
ilevkivskyi
ilevkivskyi approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks! Could you please also add the docs change we discussed in the issue? (delete the mention of hook not being called on assignments).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 13d6738 into python:master Oct 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianschubert @ilevkivskyi