Update the overlapping check for tuples to account for NamedTuples #18564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5rocks
commented
Jan 29, 2025
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: CPython (peg_generator) (https://github.com/python/cpython): 1.83x faster (25.4s -> 13.9s in a single noisy sample)
|
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
…ython#18564) Fixes python#18562. Fixes python#6623. Fixes python#18520. (Only incidentally and I'm not exactly sure why.) I was investigating what input mypy thought satisfied both overloads and I found that mypy is missing a check on the fallback type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18562.
Fixes #6623.
Fixes #18520. (Only incidentally and I'm not exactly sure why.)
I was investigating what input mypy thought satisfied both overloads and I found that mypy is missing a check on the fallback type.