[mypyc] Improve support for frozenset #18571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Jan 31, 2025
| @@ -0,0 +1,536 @@ | |||
| [case testNewFrozenSet] | |||
There was a problem hiding this comment.
The irbuild tests are maybe too verbose -- they may need to be updated frequently as the details of emitter IR change. My suggestion would be to avoid some duplication and to move some thing to run tests if they don't otherwise have test coverage.
There was a problem hiding this comment.
Tbh for the first implementation I mostly copied the set test cases and adjusted them slightly for frozenset. Your suggestion does make sense though. Moved some of the fromIterable tests to run_sets.test.
There was a problem hiding this comment.
Yeah some of the existing IR build tests are overly verbose.
1d2a393 to
8edec05
Compare
JukkaL
approved these changes
Jan 31, 2025
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Add optimized methods for `len` and `contains` on `frozenset` objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optimized methods for
lenandcontainsonfrozensetobjects.