Skip to content

Use lower case "list" and "dict" in invariance notes #18594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Feb 3, 2025

All supported Python versions support list[...] and dict[...].

All supported Python versions support `list[...]` and `dict[...]`.
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Diff from mypy_primer, showing the effect of this PR on open source code:

pydantic (https://github.com/pydantic/pydantic)
- pydantic/aliases.py:29: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ pydantic/aliases.py:29: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/callables.py:571: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ src/prefect/utilities/callables.py:571: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
- src/prefect/_experimental/lineage.py:261: note: "Dict" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ src/prefect/_experimental/lineage.py:261: note: "dict" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/runtime/runtime_test_case.py:86:27: note: "Dict" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ lib/tests/streamlit/runtime/runtime_test_case.py:86:27: note: "dict" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

rclip (https://github.com/yurijmikhalevich/rclip)
- rclip/model.py:214: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ rclip/model.py:214: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

comtypes (https://github.com/enthought/comtypes)
- comtypes/tools/typedesc_base.py:194: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ comtypes/tools/typedesc_base.py:194: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
- comtypes/tools/typedesc_base.py:216: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ comtypes/tools/typedesc_base.py:216: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

dragonchain (https://github.com/dragonchain/dragonchain)
- dragonchain/transaction_processor/level_4_actions_utest.py:73:50: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ dragonchain/transaction_processor/level_4_actions_utest.py:73:50: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

materialize (https://github.com/MaterializeInc/materialize)
- misc/python/materialize/zippy/all_actions.py:43: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ misc/python/materialize/zippy/all_actions.py:43: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
- misc/python/materialize/parallel_workload/database.py:484: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ misc/python/materialize/parallel_workload/database.py:484: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
- misc/python/materialize/parallel_workload/database.py:644: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ misc/python/materialize/parallel_workload/database.py:644: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
- misc/python/materialize/parallel_workload/database.py:712: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ misc/python/materialize/parallel_workload/database.py:712: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
- misc/python/materialize/cli/ci_annotate_errors.py:715: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ misc/python/materialize/cli/ci_annotate_errors.py:715: note: "list" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance

@hauntsaninja hauntsaninja merged commit 947f650 into master Feb 4, 2025
18 checks passed
@hauntsaninja hauntsaninja deleted the invariance-note branch February 4, 2025 07:06
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
All supported Python versions support `list[...]` and `dict[...]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants