Skip to content

[mypyc] Optimize str.__contains__ #18705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

[mypyc] Optimize str.__contains__ #18705

merged 2 commits into from
Feb 19, 2025

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Feb 18, 2025

@cdce8p cdce8p added the topic-mypyc mypyc bugs label Feb 18, 2025
JukkaL
JukkaL reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have a few minor comments only. Interestingly, the C API docs say "substr has to coerce to a one element Unicode string", but it doesn't seem to be true (link).

@JukkaL JukkaL merged commit 49e014a into python:master Feb 19, 2025
13 checks passed
@cdce8p cdce8p deleted the mypyc-str-contains branch February 19, 2025 11:41
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
@cdce8p @x612skm
[mypyc] Optimize str.__contains__ (python#18705)
1d819f2 
https://docs.python.org/3/c-api/unicode.html#c.PyUnicode_Contains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
topic-mypyc mypyc bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @JukkaL