Skip to content

handle arg=None in stubgenc #18768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2025
Merged

handle arg=None in stubgenc #18768

merged 1 commit into from
Mar 8, 2025

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Mar 7, 2025

resolves #18757

@asottile asottile force-pushed the none-default-stubgenc branch from 7b8fe9f to 3477deb Compare March 7, 2025 20:04
@asottile asottile force-pushed the none-default-stubgenc branch from 3477deb to d61c049 Compare March 7, 2025 20:08
hauntsaninja
hauntsaninja approved these changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with stubgenc, but this was clearly wrong, thank you!

@hauntsaninja hauntsaninja merged commit f339f2c into python:master Mar 8, 2025
13 checks passed
@asottile asottile deleted the none-default-stubgenc branch March 8, 2025 02:38
@asottile
Copy link
Contributor Author

asottile commented Mar 8, 2025

Not familiar with stubgenc, but this was clearly wrong, thank you!

heh neither was I! but I took this chance to learn a bit more about it :) thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stubgen incorrectly represents function arguments whose default is None as having no default
2 participants
@asottile @hauntsaninja