Support types as converters in attrs plugin #4917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This unblocks: python-attrs/attrs#238 |
emmatyping
requested changes
Apr 16, 2018
| [file a.py] | ||
| from typing import overload | ||
| import attr | ||
| class complex: |
There was a problem hiding this comment.
Especially since it is duplicated across several test cases, moving this to a fixture would be good.
test-data/unit/check-attr.test
Outdated
| from typing import overload | ||
| import attr | ||
|
|
||
| class complex: |
There was a problem hiding this comment.
Perhaps this should be moved to a fixture?
| class complex: | ||
| @overload | ||
| def __init__(self, re: float = 0.0, im: float = 0.0) -> None: ... | ||
| @overload |
There was a problem hiding this comment.
Could you also add tests for an overloaded converter function?
There was a problem hiding this comment.
Thanks for this note. It was actually broken!
|
Thanks for the review! I've addressed all your concerns and fixed some more things that were broken. |
|
@ethanhs is there a way to re-request review that I'm missing here? |
emmatyping
approved these changes
May 4, 2018
|
Thank you again for working on this @euresti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4729