Skip to content

Fix from p import q when p/q.py removed from fine-grained build #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2018
Merged

Fix from p import q when p/q.py removed from fine-grained build #4988

merged 1 commit into from
May 1, 2018

Conversation

msullivan
Copy link
Collaborator

No description provided.

@msullivan msullivan requested review from JukkaL and ilevkivskyi May 1, 2018 19:18
@msullivan msullivan force-pushed the fix-missing-module-thing branch from 2b576d1 to c3c23c3 Compare May 1, 2018 19:26
JukkaL
JukkaL reviewed May 1, 2018
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix! Feel free to merge if the build passes.

@msullivan msullivan merged commit c0f2f95 into master May 1, 2018
@msullivan msullivan deleted the fix-missing-module-thing branch May 1, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL left review comments

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msullivan @JukkaL