Fix access to operators on metaclass through typevar #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
May 6, 2018
| return self.has_member(typ.item.type.metaclass_type, member) | ||
| if isinstance(typ.item, AnyType): | ||
| item = typ.item | ||
| if isinstance(item, TypeVarType): |
There was a problem hiding this comment.
I wonder shouldn't we add the same fallback to upper bound at the very top of this function? For example if I have just
def f(x: T) -> T:
x + 0| S = TypeVar("S", bound=Test) | ||
|
|
||
| def f(x: Type[Test]) -> str: | ||
| return x * 0 |
There was a problem hiding this comment.
This will still pass if the inferred type will become Any. I would either add an explicit reveal_type or add --warn-return-any flag in this test.
There was a problem hiding this comment.
I've avoided reveal_type since it passes with the broken code too. But I agree it should be added just to know it's not Any.
ilevkivskyi
approved these changes
May 7, 2018
| @@ -2431,6 +2431,10 @@ def has_member(self, typ: Type, member: str) -> bool: | |||
| """Does type have member with the given name?""" | |||
| # TODO: refactor this to use checkmember.analyze_member_access, otherwise | |||
| # these two should be carefully kept in sync. | |||
| if isinstance(typ, TypeVarType): | |||
| typ = typ.upper_bound | |||
There was a problem hiding this comment.
Could you also add a test case for this branch? (Similar to the one you already have.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4929: typevars were not handled correctly on
has_member.The test uses multiplication instead of addition since adding
__radd__to the stub reveals several inconsistencies in unrelated tests.