Refactoring: Cleanup DataSuite fields #5075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple changes to DataSuite, I believe they make things somewhat more readable and explicit.
base_path
totest_temp_dir
; this clearly marks tests that do something unusualoptional_out
torequired_out_section
and default toFalse
update_data
, and inline the only place it is used. The flag might be reintroduced if the functionality will be shared with other suitesdata_prefix
, since it is not written anywhere