Skip to content

Refactoring: Cleanup DataSuite fields #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2018

Conversation

elazarg
Copy link
Contributor

@elazarg elazarg commented May 18, 2018

Simple changes to DataSuite, I believe they make things somewhat more readable and explicit.

  • Default base_path to test_temp_dir; this clearly marks tests that do something unusual
  • Rename optional_out to required_out_section and default to False
  • Remove update_data, and inline the only place it is used. The flag might be reintroduced if the functionality will be shared with other suites
  • Document reason for data_prefix, since it is not written anywhere

* Default base_path to test_temp_dir
* Rename optional_out to required_out_section and default to False
* Remove update_data, and inline the only place it is used
* Document reason for data_prefix

base_path = test_temp_dir

# Allow mypyc to update to using a recent version of mypy. See #4779
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Allow external users of the test code to override the data prefix" or something

Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@msullivan msullivan merged commit 1566118 into python:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants