Fix testcmdline when it is run with py.test -n0 #5113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runner sets PYTHONPATH when parallelized but not with -n0. Our subprocess was depending on this to find mypy. We should set up the state we care about ourselves, so just do that. The common failure mode here was the tests failing, but I also ran into a more terrifying mode where it was invoking my installed system mypy! This is basically the same fix elazarg proposed in #4127 but that never went anywhere for unclear reasons. Fixes #4127.
|
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner sets PYTHONPATH when parallelized but not with -n0.
Our subprocess was depending on this to find mypy. We should set up
the state we care about ourselves, so just do that.
The common failure mode here was the tests failing, but I also ran
into a more terrifying mode where it was invoking my installed system
mypy!
This is basically the same fix elazarg proposed in #4127 but that
never went anywhere for unclear reasons.
Fixes #4127.