Fix fine-grained dependencies for super() #5793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes both normal and logical dependencies. We now generate dependencies of potential target attributes in base classes. Also, we don't generate logical dependencies based on the type object in Python 2 style `super()` expressions, since they aren't relevant.
ilevkivskyi
approved these changes
Oct 16, 2018
test-data/unit/deps.test
Outdated
| class D(C): | ||
| def __init__(self): # type: () -> None | ||
| super(B, self).__init__() | ||
| def mm(self): # type: () -> None |
There was a problem hiding this comment.
Why function signature on the same line here and above? This looks unusual.
There was a problem hiding this comment.
No particular reason. I'll move them to separate lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both normal and logical dependencies. We now generate
dependencies from potential target attributes in base classes. Also,
we don't generate logical dependencies based on the type object
in Python 2 style
super()expressions, since they aren'trelevant.