Add missing dependency from missing module attribute #5861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Oct 31, 2018
| [out] | ||
| <a.C.x> -> m | ||
| <a.C> -> m | ||
|
|
There was a problem hiding this comment.
I would add a fine grained test too, so that it will not regress for other (non dependency caused) reasons.
| @@ -604,6 +604,10 @@ def visit_member_expr(self, e: MemberExpr) -> None: | |||
| # No type available -- this happens for unreachable code. Since it's unreachable, | |||
| # it wasn't type checked and we don't need to generate dependencies. | |||
| return | |||
| if isinstance(e.expr, RefExpr) and isinstance(e.expr.node, MypyFile): | |||
| # Special case: reference to a missing module attribute. | |||
There was a problem hiding this comment.
I would also update the comment few lines above (can't comment there):
# Reference to a non-module attribute -> # Reference to a non-module (or missing) attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4782.