Skip to content

Add options attribute to all plugin APIs #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Add options attribute to all plugin APIs #5890

merged 1 commit into from
Nov 13, 2018

Conversation

dgelessus
Copy link
Contributor

(as suggested on Gitter by @ilevkivskyi)

This allows plugins to behave differently based on options like the Python version.

@dgelessus
Add options attribute to all plugin APIs
cd864bd 
This allows plugins to behave differently based on options like the
Python version.
ilevkivskyi
ilevkivskyi approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@ilevkivskyi ilevkivskyi merged commit 70fcb0b into python:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgelessus @ilevkivskyi