Always set correct kind for module __getattr__ #5893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Nov 14, 2018
| @@ -2627,3 +2627,35 @@ import foo.bar.baz | |||
| reveal_type(foo.bar.baz.x) # E: Revealed type is 'builtins.int' | |||
| [file foo/bar/baz.py] | |||
| x = 0 | |||
|
|
|||
| [case testModuleGetAttrAssignUnannotated] | |||
There was a problem hiding this comment.
What about testing a package with a missing explicit submodule (__getattr__ in __init__) and then assigning something to a submodule attribute? Or is this still unsupported?
There was a problem hiding this comment.
OK, I added two tests for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5866
There are two places where
__getattr__generatedVars are created, and somehow in one of them it was given aMDEFkind (which caused a crash), although it is a module attribute.