Skip to content

Lazily import write_junit_xml from dmypy #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Lazily import write_junit_xml from dmypy #5907

merged 1 commit into from
Nov 17, 2018

Conversation

msullivan
Copy link
Collaborator

This speeds dmypy status and dmypy check on my test MBP by a
whopping 120ms! (But only about 40ms on my Linux laptop.)

This speeds `dmypy status` and `dmypy check` on my test MBP by a
whopping 120ms! (But only about 40ms on my Linux laptop.)
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Good catch.

@msullivan msullivan merged commit 2680c3f into master Nov 17, 2018
@msullivan msullivan deleted the dmypy-opt branch November 17, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants