Fixed overlapped I/O when more data needs to be read #6272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the tests didn't capture this, but ReadFile, not GetOverlappedResult returns _winapi.ERROR_MORE_DATA, which means that we would not do another read. This handles that and correctly peeks then reads the remaining data.
msullivan
approved these changes
Jan 30, 2019
| self.name = name | ||
| self.timeout = timeout | ||
|
|
||
| def read(self) -> bytes: | ||
| def read(self, size: int = 100000) -> bytes: |
There was a problem hiding this comment.
I'm not sure if this is worth putting in the interface, since it doesn't modify any visible behavior.
There was a problem hiding this comment.
I just felt it was more fitting to put it in the function scope since it is only used for reads. To me it makes the code easier to understand (one less instance attribute to think about in the other methods).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the tests didn't capture this, but ReadFile, not GetOverlappedResult returns _winapi.ERROR_MORE_DATA, which means that we would not do another read (instead we would fail an assert). This handles the case where there is more data to be read and correctly peeks then reads the remaining data.
I also increased the size of the test message to make sure we don't miss errors like this in the future, and added more information when assertions fail.