Skip to content

Have --package usage respect mypy_path #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

Have --package usage respect mypy_path #6926

merged 1 commit into from
Jun 20, 2019

Conversation

abatilo
Copy link
Contributor

@abatilo abatilo commented Jun 2, 2019

Addresses:
#6595

@blueyed
Copy link
Contributor

blueyed commented Jun 3, 2019

Needs a test (#6595 (comment)), but maybe wait for some other feedback first.

@emmatyping emmatyping self-requested a review June 3, 2019 09:39
@emmatyping
Copy link
Member

@abatilo I believe you can make a modified version of this test case where you write a mypy.ini in venv_dir and pass that with --config-file to mypy. Leave a message when you are done and I can review this.

@abatilo
Copy link
Contributor Author

abatilo commented Jun 9, 2019

@ethanhs After much fighting with the CI checks, I think I finally have a test that I can be proud of, and one that did in fact fail before the accompanying change was made. Please let me know if there's anything I need to change!

@emmatyping
Copy link
Member

@abatilo sorry for the delay, I will review this tomorrow.

emmatyping
emmatyping approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this!

@abatilo
Copy link
Contributor Author

abatilo commented Jun 13, 2019

My first OSS contribution!!! :D

@emmatyping
Copy link
Member

Unless someone else wants to review this/has further feedback I will merge this tomorrow.

@abatilo
Copy link
Contributor Author

abatilo commented Jun 20, 2019

@ethanhs Ping on this.

@emmatyping emmatyping merged commit 6bbc3df into python:master Jun 20, 2019
@emmatyping
Copy link
Member

@abatilo Thank you for your contribution!

PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@abatilo @PattenR
Have --package usage respect mypy_path (python#6926)
6605700 
Fixes python#6595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abatilo @blueyed @emmatyping