Support flexible option specification in config file and inline configuration #7054
Conversation
mypy/config_parser.py
Outdated
| elif callable(ct): | ||
| if invert: | ||
| print("%sCan not invert non-boolean key %s" % (prefix, options_key), file=stderr) |
There was a problem hiding this comment.
Should this kind of errors be sys.exit(2)?
There was a problem hiding this comment.
- Probably
- Similar errors are not
There was a problem hiding this comment.
@gvanrossum What do you think?
There was a problem hiding this comment.
When the mypy.ini file was new, I decided to make errors in the config file just print warnings. I can't recall why, possibly because the control flow to make them real errors was complex, or possibly because I was worried that people would have junk in their config files.
I'd stick to this tradition for now and do a separate sweep to clean it up later. (Maybe sections we don't recognize should not be fatal but in recognized sections, flags we don't understand should be fatal?)
There was a problem hiding this comment.
I'd stick to this tradition for now and do a separate sweep to clean it up later.
SGTM.
I don't think it really will? Certain configurations that currently produce a warning will instead have meaning, but I don't think that counts. |
Support inverting options based on
no_, and adding or removing adisprefixin the config file (and therefore in inline configuration also).
This moves the handling of
no_prefixes from inline configuration to the config file.As a result, the config file is brought closer into alignment with the command line options.