Skip to content

New analyzer: don't reprocess member expressions that are already bound #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

New analyzer: don't reprocess member expressions that are already bound #7230

merged 1 commit into from
Jul 17, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #7229

The fix is to not reprocess member expressions that are already bound. We already do this for name expressions.

As a small bonus this may give a minor perf boost.

@ilevkivskyi ilevkivskyi requested a review from JukkaL July 17, 2019 10:11
JukkaL
JukkaL approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response! Looks good.

@ilevkivskyi ilevkivskyi merged commit b405e05 into python:master Jul 17, 2019
@ilevkivskyi ilevkivskyi deleted the fix-final branch July 17, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious final errors in function referencing undefined variable
2 participants
@ilevkivskyi @JukkaL