Skip to content

Use union component as a self-type in class methods #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

Use union component as a self-type in class methods #7822

merged 1 commit into from
Oct 30, 2019

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Oct 30, 2019 •
edited by JukkaL
Loading

Fixes #7821

The same logic is already used for normal methods, I think class methods should be no different.

@ilevkivskyi ilevkivskyi requested a review from JukkaL October 30, 2019 11:25
JukkaL
JukkaL approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilevkivskyi ilevkivskyi merged commit 7e7b1e4 into python:master Oct 30, 2019
@ilevkivskyi ilevkivskyi deleted the fix-union-self-classmethod branch October 30, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Self-type in class method doesn't work on unions
2 participants
@ilevkivskyi @JukkaL