Skip to content

Add missing explicit Optional to stubs for the xml.etree package. #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Add missing explicit Optional to stubs for the xml.etree package. #2734

merged 2 commits into from
Jan 17, 2019

Conversation

mrshannon
Copy link
Contributor

This fixes #2733 as well as making Optional explicit for the rest of the xml.etree package as per the guidelines on implicit vs. explicit Optional for None defaults.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srittau srittau merged commit a2ecfaf into python:master Jan 17, 2019
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of explicit Optional in xml.etree.ElementTree.
2 participants