Enable selective build in OSS #11540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11540
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a6298d4 with merge base 72a095f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D76380110 |
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
BujSet
approved these changes
Jun 11, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: BujSet Differential Revision: D76380110 Pulled By: larryliu0820
d132bfa to
4b3b013
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76380110 |
larryliu0820
added a commit
that referenced
this pull request
Jun 11, 2025
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: BujSet Differential Revision: D76380110 Pulled By: larryliu0820
4b3b013 to
59e2b37
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76380110 |
larryliu0820
added a commit
that referenced
this pull request
Jun 11, 2025
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Pull Request resolved: #11540 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: BujSet Differential Revision: D76380110 Pulled By: larryliu0820
59e2b37 to
3e685f1
Compare
lucylq
approved these changes
Jun 11, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq, BujSet Differential Revision: D76380110 Pulled By: larryliu0820
3e685f1 to
06712a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76380110 |
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq, BujSet Differential Revision: D76380110 Pulled By: larryliu0820
06712a4 to
a6298d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76380110 |
BujSet
pushed a commit
to BujSet/executorch
that referenced
this pull request
Jun 11, 2025
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq, BujSet Differential Revision: D76380110 Pulled By: larryliu0820
BujSet
pushed a commit
to BujSet/executorch
that referenced
this pull request
Jun 11, 2025
Summary: This pull request introduces a new `selective_build` pybind module to enhance code generation tools in the `executorch` project. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing. ### Module Creation: * Added `selective_build.cpp` to define the `selective_build` pybind module, which provides functionality for extracting operator and IO metadata from serialized programs. * Added type definitions in `selective_build.pyi` for the `selective_build` module, including `_Program`, `_IOMetaData`, and associated methods. ### Integration into Build System: * Updated `CMakeLists.txt` to include the `codegen/tools` directory for the `selective_build` module when `EXECUTORCH_BUILD_PYBIND` is enabled. * Modified `setup.py` to add `selective_build` as a build target and link it to the appropriate CMake flags. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R732) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R794-R798) * Updated `targets.bzl` to define build rules for the `selective_build` module and its dependencies, ensuring compatibility with the runtime environment. [[1]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL22-R22) [[2]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fL32-R32) [[3]](diffhunk://#diff-3847c39f66d06290c190e38ef87820edbe0a9f8193db33bd556376123eb4875fR158-R195) ### Testing: * Added `test/test_selective_build.py` to validate the functionality of the `selective_build` module, including tests for operator extraction and IO metadata retrieval. Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: lucylq, BujSet Differential Revision: D76380110 Pulled By: larryliu0820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
selective_buildpybind module to enhance code generation tools in theexecutorchproject. It includes changes to integrate the module into the build system, define its functionality, and add tests for validation. The most important changes are grouped into themes: module creation, integration into the build system, and testing.Module Creation:
selective_build.cppto define theselective_buildpybind module, which provides functionality for extracting operator and IO metadata from serialized programs.selective_build.pyifor theselective_buildmodule, including_Program,_IOMetaData, and associated methods.Integration into Build System:
CMakeLists.txtto include thecodegen/toolsdirectory for theselective_buildmodule whenEXECUTORCH_BUILD_PYBINDis enabled.setup.pyto addselective_buildas a build target and link it to the appropriate CMake flags. [1] [2]targets.bzlto define build rules for theselective_buildmodule and its dependencies, ensuring compatibility with the runtime environment. [1] [2] [3]Testing:
test/test_selective_build.pyto validate the functionality of theselective_buildmodule, including tests for operator extraction and IO metadata retrieval.Differential Revision: D76380110