Skip to content

Conversation

snazy
Copy link
Contributor

@snazy snazy commented Aug 18, 2022

Adds missing support for classes referenced by @JsonTypeIdResolver, which is particularly important when using native builds.

The added integration tests are likely only meaningful when run in native mode (-Pnative), otherwise "good old Java reflection" does its job.

Fixes #27346

@quarkus-bot quarkus-bot bot added the area/jackson Issues related to Jackson (JSON library) label Aug 18, 2022
Adds missing support for classes referenced by `@JsonTypeIdResolver`, which is particularly important when using native builds.

The added integration tests are likely only meaningful when run in native mode (`-Pnative`), otherwise "good old Java reflection" does its job.

Fixes quarkusio#27346
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks but let's wait for @geoand 's opinion too.

@gsmet gsmet requested a review from geoand August 18, 2022 20:21
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 4f53bdd into quarkusio:main Aug 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 22, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.0.Final Aug 23, 2022
snazy added a commit to snazy/nessie that referenced this pull request Aug 26, 2022
Quarkus 2.12 is now released and used in Nessie, with quarkusio/quarkus#27357

Fixes projectnessie#4955
snazy added a commit to snazy/nessie that referenced this pull request Aug 26, 2022
Quarkus 2.12 is now released and used in Nessie, with quarkusio/quarkus#27357

Fixes projectnessie#4955
snazy added a commit to projectnessie/nessie that referenced this pull request Aug 26, 2022
Quarkus 2.12 is now released and used in Nessie, with quarkusio/quarkus#27357

Fixes #4955
@snazy snazy deleted the json-type-id-resolver branch September 1, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library) kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jackson: also detect class referenced by @JsonTypeIdResolver
3 participants