fix: line endings on Windows #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces a
.gitattributes
file into this repo to forcegit
to uself
rather thancrlf
line endings on Windows. Without it, runningyarn lint
results in thousands of errors like this for Windows users:This fix is the one suggested by the ESLint documentation:
https://eslint.org/docs/rules/linebreak-style#using-this-rule-with-version-control-systems
Test Plan:
Running
yarn lint
works properly on Windows with this fix in place.