Skip to content

Fix: problem on run-android with deviceId #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 12, 2019
Merged

Fix: problem on run-android with deviceId #137

merged 5 commits into from
Feb 12, 2019

Conversation

ifsnow
Copy link
Contributor

@ifsnow ifsnow commented Jan 31, 2019 •
edited by thymikee
Loading

Fixes #132

  • Works well with enableSeparateBuildPerCPUArchitecture, universalApk options.
  • Even if it is already installed, it works normally. (Added -r option to adb install)

I hope this helps.

@thymikee
Copy link
Member

Thanks @ifsnow, appreciated! Would you mind fixing lint/flow?

@ifsnow ifsnow force-pushed the fix/run-android-with-deviceId branch from 9ba96b5 to 073389f Compare January 31, 2019 09:39
@ifsnow
Copy link
Contributor Author

ifsnow commented Jan 31, 2019

@thymikee Sure! All modified.

@thymikee
Copy link
Member

@ferrannp can you have a look?

@thymikee thymikee requested a review from Esemesek January 31, 2019 09:55
ferrannp
ferrannp reviewed Jan 31, 2019
View reviewed changes
Esemesek
Esemesek reviewed Jan 31, 2019
View reviewed changes
grabbou
grabbou reviewed Jan 31, 2019
View reviewed changes
@ifsnow ifsnow force-pushed the fix/run-android-with-deviceId branch from dcb15cc to 2c2c8f9 Compare February 1, 2019 07:53
@ifsnow
Copy link
Contributor Author

ifsnow commented Feb 1, 2019

@grabbou @thymikee @ferrannp @Esemesek I think there was some problems with how to use output.json mentioned above. For example, some users delete this file. so, It seems most reasonable to find the appropriate apk file for the target device's cpu via adb.

Please review my new approach.

krizzu
krizzu reviewed Feb 1, 2019
View reviewed changes
krizzu
krizzu reviewed Feb 1, 2019
View reviewed changes
grabbou
grabbou reviewed Feb 11, 2019
View reviewed changes
grabbou
grabbou reviewed Feb 11, 2019
View reviewed changes
Copy link
Member

@grabbou grabbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for working on it and addressing all the feedback. Just left two last comments and we are good to go!

Let me know what you think!

@ifsnow
Copy link
Contributor Author

ifsnow commented Feb 12, 2019

@grabbou I'm done. Please let me know if you have any reviews.

@thymikee
Copy link
Member

@krizzu can you give it one more look?

@grabbou grabbou merged commit b3c20b9 into react-native-community:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrannp ferrannp ferrannp left review comments

@grabbou grabbou grabbou left review comments

@thymikee thymikee thymikee left review comments

@Esemesek Esemesek Esemesek left review comments

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ifsnow @thymikee @ferrannp @grabbou @krizzu @Esemesek