fix: Fix flow erros#79
Merged
thymikee merged 3 commits intoreact-native-community:masterfrom Jan 11, 2019
Esemesek:fix-flow-errors
Merged
fix: Fix flow erros#79thymikee merged 3 commits intoreact-native-community:masterfrom Esemesek:fix-flow-errors
thymikee merged 3 commits intoreact-native-community:masterfrom
Esemesek:fix-flow-errors
Conversation
ferrannp
approved these changes
Jan 11, 2019
thymikee
approved these changes
Jan 11, 2019
| const packageName = fs | ||
| .readFileSync(`${appFolder}/src/main/AndroidManifest.xml`, 'utf8') | ||
| // $FlowFixMe | ||
| .match(/package="(.+?)"/)[1]; |
Member
There was a problem hiding this comment.
Match result may be null so that's a valid bug. We should catch such scenario and throw an error that package is missing in AndroidManifest.xml. Can be done as a followup
| const scriptsDir = path.resolve(__dirname, '..', '..', 'scripts'); | ||
| const launchPackagerScript = path.resolve(scriptsDir, scriptFile); | ||
| const procConfig = { cwd: scriptsDir }; | ||
| const procConfig: Object = { cwd: scriptsDir }; |
Member
|
Merging to unbreak master, but the comments remain valid and I'd appreciate some discussion/followup :) |
This was referenced Jan 11, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing flow errors. In some places, I removed
@flowannotation because its module was never entirely typed, and adding types would require much more effort, than this simple fix.EDIT: Also removed
dependenciescommand since it exists already inmetro.PR: facebook/metro#335
Renaming cmd in
metro: facebook/metro#339