Skip to content

Do not pass DnD classes down to nested groups #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

jakeboone02
Copy link
Member

Fixes #399.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18c3203:

Sandbox Source
react-querybuilder-ci Configuration
react-querybuilder-dnd-example Configuration
react-querybuilder-antd-example Configuration
react-querybuilder-bootstrap-example Configuration
react-querybuilder-bulma-example Configuration
react-querybuilder-chakra-example Configuration
react-querybuilder-material-example Configuration

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #401 (18c3203) into main (cbecaf8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #401   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         3079      3075    -4     
  Branches      1473      1472    -1     
=========================================
- Hits          3079      3075    -4     
Impacted Files Coverage Δ
packages/dnd/src/RuleDnD.tsx 100.00% <ø> (ø)
packages/dnd/src/hooks/useDragCommon.ts 100.00% <ø> (ø)
packages/dnd/src/hooks/useInlineCombinatorDnD.ts 100.00% <ø> (ø)
packages/dnd/src/hooks/useRuleDnD.ts 100.00% <ø> (ø)
packages/dnd/src/hooks/useRuleGroupDnD.ts 100.00% <ø> (ø)
packages/dnd/src/RuleGroupDnD.tsx 100.00% <100.00%> (ø)
packages/react-querybuilder/src/Rule.tsx 100.00% <100.00%> (ø)
packages/react-querybuilder/src/RuleGroup.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@mxcapo mxcapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great. thanks so much for hopping on this fix so quickly!

@jakeboone02 jakeboone02 merged commit 3cab7c3 into main Nov 21, 2022
@jakeboone02 jakeboone02 deleted the issue-399 branch November 21, 2022 17:46
@jakeboone02
Copy link
Member Author

No problem, @mxcapo! v5.1.2 was released with the fix just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dndOver class should not be applied to child rule group headers
2 participants